Claude Opus 5.5 · Balanced

feature-automatically-downsize-large-images-discourse-cursor

Discourse · Ruby · S · 30–99 lines · 3 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
3 of 8
Comments published
4
Comments matching a bug
3
Comments not matching
1
Cost of this PR
$0.571

Published comments (4)

highbugapp/models/optimized_image.rb:145-151

Second `downsize` definition overrides the width/height variant — `Jobs::ResizeEmoji` still calls `OptimizedImage.downsize(path, path, 100, 100, opts)`, which now raises `ArgumentError` and breaks emoji resizing. Ruby has no overloading, so rename one method (e.g. `downsize_to_dimensions`) or keep a single `downsize` that builds the dimensions string from width and height.

highbugapp/controllers/uploads_controller.rb:65-69

Animated GIF downsize passes a percentage gifsicle rejects and retries after failure — gifsicle likely rejects the `--resize-fit 80%` from `downsize_instructions_animated`, so animated GIFs never shrink and the loop spawns five failing processes. Pass pixel dimensions on the animated path and break the loop when `downsize` returns `false`.

highbugapp/assets/javascripts/discourse/lib/utilities.js:180-185

Fixed 10MB upload limit ignores configured max image/attachment sizes — Attachments over `max_attachment_size_kb` pass this check and fail only on the server, while images an admin allowed above 10MB are wrongly rejected. Apply the 10MB floor only to images, e.g. `max(max_image_size_kb, 10MB)`, and keep `Discourse.SiteSettings['max_' + type + '_size_kb']` for attachments.

mediumsecurityapp/controllers/uploads_controller.rb:63-70

Oversized images are decoded by ImageMagick without a pixel-dimension check — A small, highly compressed file with huge pixel dimensions can exhaust server CPU and memory across up to 5 `downsize` passes, and in synchronous API mode this runs inside the request. Check pixel dimensions with `FastImage` before calling `downsize` and reject oversized images, or cap `convert` with `-limit`.

Gold bugs found (3)

highdownsize is defined twice in OptimizedImage; the new (from, to, dimensions, opts) version overrides the (max_width, max_height) one, so existing callers such as ResizeEmoji that pass width and height now raise ArgumentError.
highThe client-side upload size check hardcodes 10 MB instead of the per-type max_<type>_size_kb setting, so attachment limits diverge from the server: larger allowed attachments are blocked and smaller limits are only enforced server-side.
highThe upload downsizing passes a percentage ('80%') as dimensions, but for animated GIFs the gifsicle path uses --resize-fit, which expects WxH geometry, so downsizing silently fails.

Gold bugs missed (5)

mediumAuto-downsizing passes the upload tempfile path, which lacks a .gif extension, so the animated branch is never chosen and convert keeps only the first frame, flattening oversized animated GIFs.
highClaims the downsize loop checking tempfile.size may never terminate because of a stale cached size, causing infinite loops.
highOversized SVG uploads go through the new ImageMagick downsize loop because SVG counts as an image, so the vector file is rasterized or corrupted in place before Upload.create_for parses it as SVG.
criticalThe upload tempfile path, which for API URL uploads embeds the request-controlled type param, is now passed to OptimizedImage.downsize and run unescaped in a shell via backticks, allowing command injection through type.
mediumThe 413 upload error message states a hard-coded 10 MB maximum that may not match the limit the server or web server actually enforces.