Claude Opus 5.5 · Balanced

github-oauth-security-enhancement-sentry

Sentry · Python · M · 100–299 lines · 2 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
0 of 1
Comments published
3
Comments matching a bug
0
Comments not matching
3
Cost of this PR
$0.657

Published comments (3)

highsecuritysrc/sentry/integrations/github/integration.py:475-482

Installation ownership check skipped when Integration doesn't exist yet — A user who submits someone else's `installation_id` before the installation webhook arrives can link that GitHub installation to their own org, because `build_integration` trusts the query string. Before calling `next_step()`, fetch or require the installation sender and compare it to `github_authenticated_user`.

mediumbugsrc/sentry/integrations/github/integration.py:500-505

KeyError when integration metadata has no sender during reinstall — `build_integration` sets the sender only when state has it, so reinstalling an Integration without one fails with a 500 from `integration.metadata["sender"]["login"]` instead of showing the error page. Read it with `.get()` and return `error(...)` when no sender is recorded.

mediumbugsrc/sentry/integrations/github/integration.py:423-436

Unhandled errors from `get_user_info` crash the GitHub setup view — An expired or revoked token, a GitHub 4xx/5xx, or a network error makes `raise_for_status()` or `resp.json()` inside `get_user_info` crash the view with a 500 instead of rendering the installation-failed page. Catch these errors and return `error(request, self.active_organization)`.

Gold bugs found (0)

None.

Gold bugs missed (1)

mediumtest_installation_not_found uses a wrong OAuth state, so it fails at the state check and never reaches the installation-not-found path it is meant to test.