Claude Opus 5.5 · Heavy

replays-self-serve-bulk-delete-system-sentry

Sentry · Python · M · 100–299 lines · 3 files

The generalist plus 9 specialist lens agents in parallel, then the same verify and dedup steps. Judge: Claude Haiku 5.5.

Gold bugs found
4 of 10
Comments published
5
Comments matching a bug
4
Comments not matching
1
Cost of this PR
$12.900

Published comments (5)

mediumbugstatic/app/views/performance/newTraceDetails/traceDrawer/details/span/eapSections/attributes.tsx:65-69

Hidden attributes still shown when the search query is empty — In the default view with no search, `is_segment`, `project_id` and `received` still appear because the early return on `searchQuery.trim()` skips the `HIDDEN_ATTRIBUTES` filter. Filter out hidden attributes before the early return so they are removed in every case.

mediumbugtests/sentry/replays/tasks/test_delete_replays_bulk.py:94-99

Test with None max_segment_id never exercises the null guard — Because `delete_matched_rows` is mocked, `_make_recording_filenames` never runs, so this test would still pass with the null guard removed. Add a test that calls `_make_recording_filenames` or the real `delete_matched_rows` with `max_segment_id` set to `None` and asserts no filenames and no error.

mediumbugsrc/sentry/replays/endpoints/project_replay_summarize_breadcrumbs.py:107-119

Error events matched to wrong IDs when zipping unordered get_multi results — `nodestore.backend.get_multi` drops duplicate ids and returns uncached items before cached ones, so `zip(error_ids, events.values())` can attach the wrong event id to each title and message. Look up each event by node id, e.g. `events.get(node_id)` while zipping `error_ids` with `node_ids`.

mediumbugsrc/sentry/replays/endpoints/project_replay_summarize_breadcrumbs.py:153-155

Error timestamps in seconds compared to breadcrumb timestamps in milliseconds — Convert both sides to the same unit before comparing.

mediumbugsrc/sentry/issues/endpoints/browser_reporting_collector.py:50-60

Mutual-exclusion checks treat age/timestamp of 0 as absent — With truthiness checks, `age: 0` or `timestamp: 0`, which `min_value=0` allows, counts as absent, so a report sending both fields is accepted. Check key presence instead, e.g. `"age" in self.initial_data`.

Gold bugs found (4)

mediumThe age/timestamp mutual-exclusion validators check truthiness via initial_data.get(), so a zero value is treated as absent and a report carrying both fields passes validation.
mediumHIDDEN_ATTRIBUTES is applied only when a search query is present; the no-search early return shows all attributes, so the hidden attributes still appear in the default span attributes view.
mediumThe bulk delete test sets max_segment_id to None to cover the new guard in _make_recording_filenames, but it mocks delete_matched_rows, so the guard is never executed and removing it would not fail the test.
mediumError event timestamps (seconds) are compared with replay recording event timestamps (milliseconds), so errors are not interleaved chronologically with breadcrumbs.

Gold bugs missed (6)

mediumThe validation-failure warning logs the entire raw, attacker-controlled browser report instead of a redacted subset.
mediumThe Snuba replay lookup for error IDs runs even when enable_error_context=false, adding a needless query (and failure point) to opt-out requests.
highWith the use-table-widget-visualization flag on, the widget renders TableWidgetVisualization with hardcoded empty columns and data instead of the query results, so every table widget shows an empty table.
mediumThe custom cell renderers fall back to default rendering on any falsy return (0, '', null), not only undefined, so a renderer cannot render zero or an empty cell.
mediumThe attribute-keys query key no longer includes the organization slug, so two organizations with the same filters share a cache entry and switching orgs can show the previous org's attribute names.
mediumEvery paginated breadcrumb-summary request queries the replay and fetches all of its error events from nodestore with no cap, adding latency and memory proportional to the replay's error count on each page.