Claude Sonnet 5.5 · Balanced

replays-self-serve-bulk-delete-system-sentry

Sentry · Python · M · 100–299 lines · 3 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
2 of 10
Comments published
2
Comments matching a bug
2
Comments not matching
0
Cost of this PR
$1.520

Published comments (2)

mediumbugsrc/sentry/replays/endpoints/project_replay_summarize_breadcrumbs.py:153-155

Error timestamps in seconds compared with replay timestamps in milliseconds — Every error sorts before the first replay event, so the log sent to Seer is no longer chronological. Normalize the units, for example by multiplying the error timestamp by 1000 or by dividing the `timestamp` of each replay event by 1000.

mediumbugsrc/sentry/issues/endpoints/browser_reporting_collector.py:50-60

Age/timestamp exclusivity check misses zero values and absent fields — Truthiness checks in `validate_timestamp` and `validate_age` accept `age=0` or `timestamp=0` alongside the other field, and a report with neither field passes. Replace them with a `validate()` method that checks key presence in `attrs` and requires exactly one.

Gold bugs found (2)

mediumThe age/timestamp mutual-exclusion validators check truthiness via initial_data.get(), so a zero value is treated as absent and a report carrying both fields passes validation.
mediumError event timestamps (seconds) are compared with replay recording event timestamps (milliseconds), so errors are not interleaved chronologically with breadcrumbs.

Gold bugs missed (8)

mediumThe validation-failure warning logs the entire raw, attacker-controlled browser report instead of a redacted subset.
mediumThe Snuba replay lookup for error IDs runs even when enable_error_context=false, adding a needless query (and failure point) to opt-out requests.
highWith the use-table-widget-visualization flag on, the widget renders TableWidgetVisualization with hardcoded empty columns and data instead of the query results, so every table widget shows an empty table.
mediumThe custom cell renderers fall back to default rendering on any falsy return (0, '', null), not only undefined, so a renderer cannot render zero or an empty cell.
mediumThe attribute-keys query key no longer includes the organization slug, so two organizations with the same filters share a cache entry and switching orgs can show the previous org's attribute names.
mediumEvery paginated breadcrumb-summary request queries the replay and fetches all of its error events from nodestore with no cap, adding latency and memory proportional to the replay's error count on each page.
mediumHIDDEN_ATTRIBUTES is applied only when a search query is present; the no-search early return shows all attributes, so the hidden attributes still appear in the default span attributes view.
mediumThe bulk delete test sets max_segment_id to None to cover the new guard in _make_recording_filenames, but it mocks delete_matched_rows, so the guard is never executed and removing it would not fail the test.