Claude Sonnet 5.5 · Heavy

sms-workflow-reminder-retry-count-tracking-cal-com

cal.com · TypeScript · S · 30–99 lines · 3 files

The generalist plus 9 specialist lens agents in parallel, then the same verify and dedup steps. Judge: Claude Haiku 5.5.

Gold bugs found
2 of 5
Comments published
2
Comments matching a bug
2
Comments not matching
0
Cost of this PR
$0.610

Published comments (2)

highbugpackages/features/ee/workflows/api/scheduleSMSReminders.ts:38-42

SMS cron deleteMany removes non-SMS reminders with retryCount > 1 — Without an SMS filter, this cleanup can silently delete email and WhatsApp reminders that have `retryCount` above 1. Add `method: WorkflowMethods.SMS` to this branch of the `deleteMany` condition.

mediumbugpackages/features/ee/workflows/api/scheduleSMSReminders.ts:189-198

Failed retryCount update in catch block aborts the whole SMS batch — If the `prisma.workflowReminder.update` in the catch block throws, the error escapes, aborts the loop, and fails the whole cron request, so one bad reminder blocks the rest. Log first and wrap the `retryCount` update in its own try/catch.

Gold bugs found (2)

highThe deleteMany OR clause applies retryCount > 1 without the SMS method filter, so the SMS cron deletes any workflow reminder (email, WhatsApp) with retryCount above 1.
mediumThe retry-count update inside the catch block is not guarded, so if it throws (for example the reminder was deleted concurrently) the error escapes the loop and the cron run fails, skipping the remaining reminders.

Gold bugs missed (3)

mediumretryCount is set to reminder.retryCount + 1 from a value read at the start of the run instead of an atomic increment, so overlapping runs can lose increments.
criticalClaims transient errors increment retryCount, so two runs during an outage delete the whole pending SMS reminder queue.
highSMS-sending locks are counted as failed scheduling attempts: scheduleSMS returns undefined for locked users/teams, retryCount is incremented, and after two cron runs the retryCount > 1 cleanup deletes future reminders even if sending is later unlocked.