DeepSeek V4.1 Flash · Balanced
add-client-resource-type-and-scopes-to-authorization-schema-keycloak
Keycloak · Java · L · 300–799 lines · 5 files
The normal review, with one generalist agent. Judge: Claude Haiku 5.5.
- Gold bugs found
- 2 of 8
- Comments published
- 4
- Comments matching a bug
- 2
- Comments not matching
- 2
- Cost of this PR
- $0.204
Published comments (4)
getClientsWithPermission returns bogus entry instead of client ids — The set ends up with the all-clients resource's literal name instead of client ids, so AvailableRoleMappingResource throws a NullPointerException on `realm.getClientById(cid)`. Iterate real clients and add `client.getId()` when `hasPermission` passes.
Existing realms miss upgrade for new CLIENTS admin resource type — Realms with ADMIN_FINE_GRAINED_AUTHZ_V2 already enabled never get the new scopes or the CLIENTS resource type, and `getOrCreateResource` fails with ModelException("No scopes found."). Add reconciliation for existing admin-permissions resource servers when the schema grows.
ClientPermissionsV2 throws on live token-exchange and permission paths — Every token-exchange request in a V2 realm now throws a 500 through `canExchangeTo`, and the client `management/permissions` endpoints fail the same way. Return false for exchange checks and a no-op for `setPermissionsEnabled` instead of throwing on live paths. **Also found in:** - `services/src/main/java/org/keycloak/services/resources/admin/permissions/AdminPermissions.java:77-95`
Client permission listings return null display names — The CLIENTS type isn't handled in the name resolution, so `getDisplayName()` stays null and PolicyResourceService returns null displayNames for every client permission listing. Resolve the client UUID to a readable label for this type.