DeepSeek V4.1 Flash · Balanced

feat-convert-insightsbookingservice-to-use-prisma-sql-raw-queries-cal-com

cal.com · TypeScript · M · 100–299 lines · 1 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
0 of 3
Comments published
1
Comments matching a bug
0
Comments not matching
1
Cost of this PR
$0.083

Published comments (1)

mediumbugpackages/lib/server/service/__tests__/insightsBooking.integration-test.ts:437-438

Deleted caching tests leave authorization/filter caching unverified — Without these tests, nothing asserts that `getAuthorizationConditions` and `getFilterConditions` cache their results, so a regression that recomputes conditions on every call would pass the suite. Restore the two caching assertions using the new `Prisma.sql` expectations.

Gold bugs found (0)

None.

Gold bugs missed (3)

mediumThe getBaseConditions test uses a single booking matching both auth and filter conditions, so it would pass even if the conditions were not combined.
mediumThe new public options type makes teamId optional for team scope, so a missing teamId compiles and silently yields empty insights instead of a type error.
highClaims getBaseConditions returns OR fragments without parentheses, so a caller appending `AND <extra>` would leak rows outside the authorization scope.