DeepSeek V4.1 Flash · Balanced

replays-self-serve-bulk-delete-system-sentry

Sentry · Python · M · 100–299 lines · 3 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
2 of 10
Comments published
3
Comments matching a bug
2
Comments not matching
1
Cost of this PR
$0.325

Published comments (3)

highbugstatic/app/views/dashboards/widgetCard/chart.tsx:164-174

Feature-flagged table branch renders empty data, discarding result and fields — With `use-table-widget-visualization` enabled, the hardcoded empty `tableData` and `columns={[]}` discard `result.data`, `result.meta`, and the widget fields, so every table widget renders empty. Pass the real result and fields, or keep `StyledSimpleTableChart` until the migration is wired up.

mediumperformancesrc/sentry/replays/endpoints/project_replay_summarize_breadcrumbs.py:104-123

Unbounded nodestore fan-out in replay breadcrumb summary error fetch — `fetch_error_details` loads every error id from nodestore per request, and `NodeStorage.get_multi` issues a backend read per id, so large replays cause unbounded fan-out. Bound the ids (e.g. the most recent N) or batch the lookup before building `node_ids`.

mediumbugsrc/sentry/replays/endpoints/project_replay_summarize_breadcrumbs.py:149-158

Error timestamps compared against replay-relative offsets — Comparing an absolute `ErrorEvent` `timestamp` against the replay-relative `event["timestamp"]` offset makes the merge test always true or always false, so errors flush as one block instead of interleaving. Normalize both to the same base before comparing.

Gold bugs found (2)

highWith the use-table-widget-visualization flag on, the widget renders TableWidgetVisualization with hardcoded empty columns and data instead of the query results, so every table widget shows an empty table.
mediumEvery paginated breadcrumb-summary request queries the replay and fetches all of its error events from nodestore with no cap, adding latency and memory proportional to the replay's error count on each page.

Gold bugs missed (8)

mediumThe age/timestamp mutual-exclusion validators check truthiness via initial_data.get(), so a zero value is treated as absent and a report carrying both fields passes validation.
mediumThe validation-failure warning logs the entire raw, attacker-controlled browser report instead of a redacted subset.
mediumThe Snuba replay lookup for error IDs runs even when enable_error_context=false, adding a needless query (and failure point) to opt-out requests.
mediumThe custom cell renderers fall back to default rendering on any falsy return (0, '', null), not only undefined, so a renderer cannot render zero or an empty cell.
mediumThe attribute-keys query key no longer includes the organization slug, so two organizations with the same filters share a cache entry and switching orgs can show the previous org's attribute names.
mediumHIDDEN_ATTRIBUTES is applied only when a search query is present; the no-search early return shows all attributes, so the hidden attributes still appear in the default span attributes view.
mediumThe bulk delete test sets max_segment_id to None to cover the new guard in _make_recording_filenames, but it mocks delete_matched_rows, so the guard is never executed and removing it would not fail the test.
mediumError event timestamps (seconds) are compared with replay recording event timestamps (milliseconds), so errors are not interleaved chronologically with breadcrumbs.