Gemini 3.8 Flash · Balanced

fix-handle-collective-multiple-host-on-destinationcalendar-cal-com

cal.com · TypeScript · S · 30–99 lines · 6 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
4 of 9
Comments published
4
Comments matching a bug
4
Comments not matching
0
Cost of this PR
$0.459

Published comments (4)

highbugpackages/core/EventManager.ts:118-121

TypeError on mainHostDestinationCalendar when destinationCalendar is empty — An empty or null `evt.destinationCalendar` triggers an unhandled `TypeError` during Google Meet bookings. Use optional chaining on `mainHostDestinationCalendar?.integration` to safely fall back to Daily video.

highbugpackages/trpc/server/routers/viewer/organizations/create.handler.ts:150-153

Inverted condition for setting organization slug — Disabling billing drops `slug`, while enabling billing incorrectly assigns both `slug` and `requestedSlug`. Revert the condition on `slug` to check `!IS_TEAM_BILLING_ENABLED`.

highbugpackages/features/bookings/lib/handleNewBooking.ts:1063-1079

destinationCalendar initialized to null drops team calendars — Collective bookings silently drop team members' calendars when the organizer lacks a destination calendar. Default `destinationCalendar` to an empty array instead of `null` so `push` can append `teamDestinationCalendars`.

highbugpackages/app-store/googlecalendar/lib/CalendarService.ts:254-256

Fallback calendar lookup searches by falsy externalCalendarId — Because `externalCalendarId` is falsy in the fallback branch, `selectedCalendar` always resolves to `undefined`. Default directly to `event.destinationCalendar?.[0]?.externalId` instead. **Also found in:** - `packages/app-store/googlecalendar/lib/CalendarService.ts:315-317`

Gold bugs found (4)

highWhen externalCalendarId is absent, updateEvent/deleteEvent look for a destination calendar whose externalId equals that absent value, so the lookup never matches and the configured destination calendar is no longer used.
highThe organization slug is now set only when team billing is enabled (inverted condition), so with billing both slug and requestedSlug are set and without billing neither is.
highThe Google Meet fallback reads mainHostDestinationCalendar.integration without optional chaining, so a Meet booking with a null or empty destinationCalendar throws instead of falling back to Cal Video.
highFor collective events whose organizer has no destination calendar, destinationCalendar is null and the optional push drops all other hosts' destination calendars, so those hosts never get calendar events.

Gold bugs missed (5)

highOffice365 (and Lark) createEvent ignore the new credentialId argument and always use the first destination calendar, so in collective bookings other hosts' credentials target the organizer's calendar instead of their own.
highVideo booking references are now saved without their credentialId, so cancelling the booking can no longer find the video credential and the meeting is not deleted.
highCancelling all remaining occurrences of a recurring collective booking deletes only the first calendar reference of each booking, repeated once per host, so the other hosts' events stay on their calendars.
mediumIn Google createEvent, when no destination calendar matches the credentialId, the hangout-link events.patch is called with an undefined calendarId and fails, so the Meet link is not added to the event description.
mediumWhen cancelling a recurring booking with multiple calendar references, the recurring-event deletion over all remaining bookings and credentials runs once per reference, causing duplicate delete calls and errors.