Gemini 3.8 Flash · Heavy
sms-workflow-reminder-retry-count-tracking-cal-com
cal.com · TypeScript · S · 30–99 lines · 3 files
The generalist plus 9 specialist lens agents in parallel, then the same verify and dedup steps. Judge: Claude Haiku 5.5.
- Gold bugs found
- 1 of 5
- Comments published
- 1
- Comments matching a bug
- 1
- Comments not matching
- 0
- Cost of this PR
- $0.342
Published comments (1)
highbugpackages/features/ee/workflows/api/scheduleSMSReminders.ts:31-43
Retry count cleanup deletes non-SMS workflow reminders — Reminders for `EMAIL` or `WHATSAPP` with `retryCount > 1` are inadvertently deleted because `method: WorkflowMethods.SMS` only scopes the first `OR` branch. Move `method: WorkflowMethods.SMS` to the top-level `where` clause alongside `OR` so both conditions apply only to SMS reminders.
Gold bugs found (1)
highThe deleteMany OR clause applies retryCount > 1 without the SMS method filter, so the SMS cron deletes any workflow reminder (email, WhatsApp) with retryCount above 1.
Gold bugs missed (4)
mediumretryCount is set to reminder.retryCount + 1 from a value read at the start of the run instead of an atomic increment, so overlapping runs can lose increments.
mediumThe retry-count update inside the catch block is not guarded, so if it throws (for example the reminder was deleted concurrently) the error escapes the loop and the cron run fails, skipping the remaining reminders.
criticalClaims transient errors increment retryCount, so two runs during an outage delete the whole pending SMS reminder queue.
highSMS-sending locks are counted as failed scheduling attempts: scheduleSMS returns undefined for locked users/teams, retryCount is incremented, and after two cron runs the retryCount > 1 cleanup deletes future reminders even if sending is later unlocked.