GLM-5.3 · Balanced
sms-workflow-reminder-retry-count-tracking-cal-com
cal.com · TypeScript · S · 30–99 lines · 3 files
The normal review, with one generalist agent. Judge: Claude Haiku 5.5.
- Gold bugs found
- 3 of 5
- Comments published
- 3
- Comments matching a bug
- 3
- Comments not matching
- 0
- Cost of this PR
- $0.512
Published comments (3)
Unprotected prisma update in catch block aborts the reminder loop and 200 response — A row deleted mid-run by `deleteScheduledSMSReminder` (or a transient DB error) makes this update throw P2025, escaping the loop, skipping remaining reminders, and losing the 200 response. Wrap the catch-block `prisma.workflowReminder.update` in its own try/catch.
Transient SMS failures counted as retries, deleting reminders that could still be sent — Both the `else` branch and `catch` increment `retryCount` even when `twilio.scheduleSMS` failed transiently — `smsLockState` LOCKED or a rate limit — so `deleteMany` irreversibly purges reminders that could still be sent. Increment only for non-retryable errors like invalid phone numbers.
`retryCount` read-modify-write loses updates on overlapping cron runs — Overlapping cron runs both read the same snapshot and write the same `retryCount: reminder.retryCount + 1`, undercounting failed attempts and letting duplicate SMS go out before `deleteMany` purges the reminder. Use atomic `retryCount: { increment: 1 }` in both update calls.