GLM-5.3 · Heavy

feat-convert-insightsbookingservice-to-use-prisma-sql-raw-queries-cal-com

cal.com · TypeScript · M · 100–299 lines · 1 files

The generalist plus 9 specialist lens agents in parallel, then the same verify and dedup steps. Judge: Claude Haiku 5.5.

Gold bugs found
0 of 3
Comments published
2
Comments matching a bug
0
Comments not matching
2
Cost of this PR
$1.953

Published comments (2)

mediumbugpackages/lib/server/service/__tests__/insightsBooking.integration-test.ts:295-299

toEqual fails against nested Prisma.Sql fragments the service returns — Because `toEqual` compares `strings`/`values` structurally, these assertions never match the nested `Sql` fragments the service composes, so three tests fail — invisibly, since this fork's CI can't run the integration job. Compose the expected value the same way (or compare `conditions.text`), or flatten in the service via `Prisma.join`.

mediumbugpackages/lib/server/service/__tests__/insightsBooking.integration-test.ts:480-484

Org/team-scope SQL array parameters are never executed by any test — Only the user-scope path ever executes, so the org/team authorization SQL — including its `ANY(${array})` parameters — has no execution evidence, and a wrong column name or unsupported array serialization would ship silently since hand-written SQL is only validated at execution. Add executing tests for those scopes via `getBaseConditions`, mirroring `insightsRouting.integration-test.ts`.

Gold bugs found (0)

None.

Gold bugs missed (3)

mediumThe getBaseConditions test uses a single booking matching both auth and filter conditions, so it would pass even if the conditions were not combined.
mediumThe new public options type makes teamId optional for team scope, so a missing teamId compiles and silently yields empty insights instead of a type error.
highClaims getBaseConditions returns OR fragments without parentheses, so a caller appending `AND <extra>` would leak rows outside the authorization scope.