GPT-6.1 Sol · Heavy
add-client-resource-type-and-scopes-to-authorization-schema-keycloak
Keycloak · Java · L · 300–799 lines · 5 files
The generalist plus 9 specialist lens agents in parallel, then the same verify and dedup steps. Judge: Claude Haiku 5.5.
- Gold bugs found
- 3 of 8
- Comments published
- 3
- Comments matching a bug
- 3
- Comments not matching
- 0
- Cost of this PR
- $2.630
Published comments (3)
All-clients manage permission does not grant coarse visibility — Callers with only all-clients `manage` can manage client scopes but cannot list them because `canListClientScopes()` and `canViewClientScopes()` inherit the `view`-only check in `canView()`; client listing also returns 403 without `query-clients`. Include all-clients `manage` in coarse visibility checks while preserving resource-specific checks for individual clients.
All-clients view grants bypass resource-specific denials — Administrators can read explicitly denied clients because `canView(ClientModel)` returns early and `ClientsResource.getClients` skips individual checks when `canView()` accepts all-clients `view`. Keep the admin-role shortcut separate from fine-grained grants, and evaluate client-specific policies before falling back to all-clients permissions, including during list filtering. **Also found in:** - `services/src/main/java/org/keycloak/services/resources/admin/permissions/ClientPermissionsV2.java:78-82` - `services/src/main/java/org/keycloak/services/resources/admin/permissions/ClientPermissionsV2.java:77-82`
Removal-denial test can pass when only the scope lookup is forbidden — The test stays green even if removal authorization breaks because `getDefaultClientScopes()` can throw the accepted `ForbiddenException` before `removeDefaultClientScope()` runs. Fetch the scope ID through the privileged `realm.admin()` client before the try block, then assert `ForbiddenException` only around the restricted client's `removeDefaultClientScope()` call.