GPT-6.1 Sol · Heavy

notification-rule-processing-engine-grafana-codex

Grafana · Go · L · 300–799 lines · 6 files

The generalist plus 9 specialist lens agents in parallel, then the same verify and dedup steps. Judge: Claude Haiku 5.5.

Gold bugs found
4 of 4
Comments published
6
Comments matching a bug
4
Comments not matching
2
Cost of this PR
$2.861

Published comments (6)

highbugpublic/app/features/alerting/unified/components/rule-viewer/AlertRuleMenu.tsx:85-87

Delete menu still requires a ruler object missing from Grafana list rows — Users with delete permission cannot delete rules from the new list because `GrafanaRuleListItem` no longer supplies `rulerRule`. Render and invoke deletion using the existing rule identifier instead of requiring `rulerRule`.

highbugpublic/app/features/alerting/unified/components/rule-viewer/AlertRuleMenu.tsx:81-83

Pause and Resume disappear for Grafana rules without ruler data — Neither Pause nor Resume appears once ruler loading is removed because the menu still requires `rulerRuleType.grafana.rule(rulerRule)`. Update the pause menu item and its rendering guard to accept the Prometheus rule or its UID and paused state.

highbugpublic/app/features/alerting/unified/rule-list/GrafanaRuleListItem.tsx:47

Silence notifications action never opens the drawer for Prometheus rules — Clicking Silence notifications only updates state because `RuleActionsButtons.V2` renders `SilenceGrafanaRuleDrawer` only for a Grafana alerting ruler rule. Update the drawer and its rendering guard to use the Prometheus rule UID supplied through `promRule`.

highbugpublic/app/features/alerting/unified/hooks/useAbilities.ts:324

Export is unavailable for Grafana-managed recording rules — Grafana-managed recording rules lose Export because `AlertRuleAction.ModifyExport` uses `isAlertingRule`, unlike the ruler-based ability. Base export support on `Boolean(rule)` rather than the alerting subtype.

mediumbugpublic/app/features/alerting/unified/hooks/useAbilities.ts:227-228

Federated rule groups lose mutation restrictions in the delegated hook — Existing consumers can now receive update/delete abilities for immutable federated groups because `useAllRulerRuleAbilities` hard-codes `isFederated` to false. Pass federation state through from `useAllAlertRuleAbilities`, or retain its `isFederatedRuleGroup(rule.group)` restriction. **Also found in:** - `public/app/features/alerting/unified/hooks/useAbilities.ts:243-245`

mediumbugpublic/app/features/alerting/unified/hooks/useAbilities.ts:397-404

Skipped Grafana rule ability checks can incorrectly grant actions — Users with Grafana create permission can see Duplicate for data-source rules whose own ability denies it because `useAllGrafanaPromRuleAbilities` treats `undefined` as eligible. Return neutral abilities for `skipToken` in `useGrafanaPromRuleAbilities` and its singular wrapper so skipped checks cannot grant actions. **Also found in:** - `public/app/features/alerting/unified/hooks/useAbilities.ts:308-318`

Gold bugs found (4)

highThe pause menu item is still gated on a Grafana ruler rule, but the list view now passes only the Prometheus rule, so Pause/Resume disappears for list-view rules even when the user may pause them.
highThe Delete menu item still requires a ruler rule, which list-view Grafana rules no longer provide, so users with delete permission lose the Delete action.
mediumWhen the Grafana prom-rule branch is skipped (datasource rules), useAllGrafanaPromRuleAbilities(undefined) still reports Duplicate as supported and allowed by Grafana create permission, and AlertRuleMenu ORs it with the ruler ability, so Duplicate appears on cloud rules even when the ruler check denies it.
highFor list-view Grafana rules RuleActionsButtons gets only promRule, so the Silence menu item is shown but the silence drawer, still gated on a ruler alerting rule, never renders and clicking Silence does nothing.

Gold bugs missed (0)

None.