GPT-6.1 Sol · Heavy

replays-self-serve-bulk-delete-system-sentry

Sentry · Python · M · 100–299 lines · 3 files

The generalist plus 9 specialist lens agents in parallel, then the same verify and dedup steps. Judge: Claude Haiku 5.5.

Gold bugs found
4 of 10
Comments published
4
Comments matching a bug
4
Comments not matching
0
Cost of this PR
$5.833

Published comments (4)

highbugstatic/app/views/dashboards/widgetCard/chart.tsx:165-173

Feature-enabled dashboard tables discard fetched results — Organizations with `use-table-widget-visualization` see empty dashboard tables even when queries return data. Pass the fetched rows, metadata, and corresponding columns to `TableWidgetVisualization` instead of empty placeholders.

mediumbugstatic/app/views/explore/hooks/useTraceItemAttributeKeys.tsx:39-41

Attribute query cache is shared across organizations — Switching organizations with matching query options reuses the previous organization's cached attributes from `useGetTraceItemAttributeKeys`. Include `organization.slug` in `queryKey` and its memo dependencies to isolate the caches.

mediumbugsrc/sentry/issues/endpoints/browser_reporting_collector.py:50-59

Zero-valued age and timestamp bypass mutual-exclusion validation — Requests containing both `age=0` and `timestamp=0` pass validation despite the mutual-exclusion requirement. In `validate_timestamp` and `validate_age`, check key presence in `self.initial_data` rather than truthiness.

mediumbugstatic/app/views/dashboards/widgets/tableWidget/defaultTableCellRenderers.tsx:70-72

Falsy custom cell results incorrectly trigger fallback rendering — Valid `renderTableBodyCell` results such as `null`, `''`, and `0` trigger fallback rendering, potentially exposing values callers intended to hide. Check `cell !== undefined` here and use the same explicit check in the corresponding header renderer.

Gold bugs found (4)

mediumThe age/timestamp mutual-exclusion validators check truthiness via initial_data.get(), so a zero value is treated as absent and a report carrying both fields passes validation.
highWith the use-table-widget-visualization flag on, the widget renders TableWidgetVisualization with hardcoded empty columns and data instead of the query results, so every table widget shows an empty table.
mediumThe custom cell renderers fall back to default rendering on any falsy return (0, '', null), not only undefined, so a renderer cannot render zero or an empty cell.
mediumThe attribute-keys query key no longer includes the organization slug, so two organizations with the same filters share a cache entry and switching orgs can show the previous org's attribute names.

Gold bugs missed (6)

mediumThe validation-failure warning logs the entire raw, attacker-controlled browser report instead of a redacted subset.
mediumThe Snuba replay lookup for error IDs runs even when enable_error_context=false, adding a needless query (and failure point) to opt-out requests.
mediumEvery paginated breadcrumb-summary request queries the replay and fetches all of its error events from nodestore with no cap, adding latency and memory proportional to the replay's error count on each page.
mediumHIDDEN_ATTRIBUTES is applied only when a search query is present; the no-search early return shows all attributes, so the hidden attributes still appear in the default span attributes view.
mediumThe bulk delete test sets max_segment_id to None to cover the new guard in _make_recording_filenames, but it mocks delete_matched_rows, so the guard is never executed and removing it would not fail the test.
mediumError event timestamps (seconds) are compared with replay recording event timestamps (milliseconds), so errors are not interleaved chronologically with breadcrumbs.