MiniMax M3 · Balanced
add-client-resource-type-and-scopes-to-authorization-schema-keycloak
Keycloak · Java · L · 300–799 lines · 5 files
The normal review, with one generalist agent. Judge: Claude Haiku 5.5.
- Gold bugs found
- 1 of 8
- Comments published
- 2
- Comments matching a bug
- 1
- Comments not matching
- 1
- Cost of this PR
- $0.249
Published comments (2)
mediumbugservices/src/main/java/org/keycloak/services/resources/admin/permissions/ClientPermissionsV2.java:262-272
getEvaluationContext is dead code in ClientPermissionsV2 — Remove the method or wire it through an actual V2 token-exchange evaluator before publishing.
mediumbugservices/src/main/java/org/keycloak/services/resources/admin/permissions/AdminPermissions.java:74-98
registerListener gate uses V1 only, dropping V2-only setups — In `AdminPermissions.registerListener`, the gate checks only V1's `ADMIN_FINE_GRAINED_AUTHZ`, so V2-only deployments never call `setPermissionsEnabled(..., false)` on role/client/group removal and orphan permission resources. Match `MgmtPermissions.java:85` by checking `ADMIN_FINE_GRAINED_AUTHZ || ADMIN_FINE_GRAINED_AUTHZ_V2`.
Gold bugs found (1)
mediumClaims the removal-cleanup listener is guarded by the V1 fine-grained flag, so client/role/group permissions are orphaned when V1 is disabled or only V2 is enabled.
Gold bugs missed (7)
highgetClientsWithPermission in ClientPermissionsV2 only finds the type-level 'Clients' resource and returns its name, never actual client ids, so callers that resolve the returned values as client ids get wrong results or null clients.
mediumClaims getResourceTypeResource can return null in ClientPermissionsV2.hasPermission, causing a NullPointerException in findByResource.
mediumClientPermissionsV2.canView() ignores a global MANAGE permission, so admins with only global manage take the unpaginated, per-client evaluated listing path.
highcanView(client) short-circuits on the global all-clients VIEW permission, so a client-specific permission denying an admin is never evaluated and the client is still viewable.
mediumThe negative check for removing a default client scope expects ForbiddenException, but it can come from the preceding getDefaultClientScopes() call, so the test passes even without a permission check on removal.
highIn ClientPermissionsV2.hasPermission, an admin granted a permission on all clients is denied on any client that also has its own per-client permission resource, because only the per-client resource is evaluated.
highClientPermissionsV2.canExchangeTo throws UnsupportedOperationException, but AbstractTokenExchangeProvider still calls clients().canExchangeTo for client-to-client exchange, so with token exchange and FGAP V2 enabled the request fails with a server error instead of a permission decision.