MiniMax M3 · Balanced

add-guest-management-functionality-to-existing-bookings-cal-com

cal.com · TypeScript · M · 100–299 lines · 6 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
2 of 8
Comments published
5
Comments matching a bug
2
Comments not matching
3
Cost of this PR
$0.174

Published comments (5)

highbugpackages/trpc/server/routers/viewer/bookings/addGuests.handler.ts:46-48

Team admin-or-owner check uses && instead of ||, blocking admins — `isTeamAdminOrOwner` wrongly rejects team ADMINs who aren't OWNERs because `&&` reduces the check to OWNER-only. Combine the two predicates with `||` so admins are authorized.

mediumbugpackages/trpc/server/routers/viewer/bookings/addGuests.handler.ts:83-90

addGuests handler stores newly added guests with an empty name — Newly added guests stored with `name: ""` produce malformed headers like ` <guest@example.com>` in `attendee-add-guests-email.ts` and drop the attendee name in `organizer-add-guests-email.ts`. Derive a display name from the email's local part instead.

mediumbugpackages/trpc/server/routers/viewer/bookings/addGuests.handler.ts:168

sendAddGuestsEmails uses unfiltered guests instead of uniqueGuests — `newGuests.includes(attendee.email)` in `email-manager.ts` reclassifies existing attendees as new when `sendAddGuestsEmails` receives the un-filtered `guests` list, sending them a full `AttendeeScheduledEmail`. Pass `uniqueGuests` so they only get `AttendeeAddGuestsEmail`.

mediumbugpackages/trpc/server/routers/viewer/bookings/addGuests.handler.ts:26-106

addGuestsHandler TOCTOU race on attendee email uniqueness — Two concurrent calls can both pass the filter and insert duplicate attendees since `Attendee` in `schema.prisma` lacks a unique `(bookingId, email)` constraint. Re-read and re-filter inside a `prisma.$transaction` so the check and `createMany` are atomic.

mediumbugapps/web/components/dialog/AddGuestsDialog.tsx:47-58

isInvalidEmail persists across retries and re-appears on edit — The inline error stays visible across retries and re-appears alongside an `onError` toast because `setIsInvalidEmail(true)` is never cleared. Reset it at the top of `handleAdd` so it reflects only the latest validation.

Gold bugs found (2)

highisTeamAdminOrOwner combines isTeamAdmin and isTeamOwner with &&, so only team owners pass; team admins who are not organizer or attendee are wrongly rejected with FORBIDDEN.
mediumThe handler passes the unfiltered guests list to sendAddGuestsEmails, which uses it to pick who gets AttendeeScheduledEmail, so existing attendees included in the request receive a new-booking confirmation instead of the add-guests email.

Gold bugs missed (6)

highThe guest blacklist is lowercased but incoming guest emails are compared without normalization, so a blacklisted address submitted with different casing bypasses BLACKLISTED_GUEST_EMAILS and is added and emailed.
mediumThe server never deduplicates the guests array, so a request with the same email twice inserts duplicate attendee rows for the booking.
highEventManager is created with the requesting user's credentials, so when a non-organizer adds guests the organizer's calendar event is not updated (or the wrong account is used) for references without a credentialId.
mediumsendAddGuestsEmails ignores the event type's disableStandardEmails settings, so hosts and attendees receive add-guests emails even when standard emails are disabled.
mediumThe add-guests handler omits booking.iCalUID from the CalendarEvent, so the add-guests emails' .ics attachments use booking.uid as UID and recipients' calendars treat them as a new event rather than an update of the original booking invite.
highGuest email uniqueness is checked case-sensitively, so case variants of the same address are accepted as distinct guests (and slip past the lowercased blacklist).