MiniMax M3 · Balanced
fix-proper-handling-of-group-memberships-discourse-cursor
Discourse · Ruby · L · 300–799 lines · 6 files
The normal review, with one generalist agent. Judge: Claude Haiku 5.5.
- Gold bugs found
- 1 of 10
- Comments published
- 4
- Comments matching a bug
- 1
- Comments not matching
- 3
- Cost of this PR
- $0.214
Published comments (4)
`update` renames group to "" when an empty name param is posted — A blank `params[:name]` is truthy in Ruby, so `group.name = params[:name] if params[:name] && !group.automatic` overwrites the group's name with `""` and fails the 422 on `group.save`. Switch the guard to `params[:name].present?` to match the `alias_level` style on the line above.
add_members drops usernames with surrounding whitespace — `add_members` splits on commas but `User.find_by_username` matches `username_lower`, so a token like `" bob"` returns `nil` and that user is silently dropped while the invite appears to succeed. Trim each token with `username.strip` before the lookup.
remove_member spec uses wrong HTTP verb for DELETE-only route — The first `.remove_member` example issues `xhr :put, :remove_member` even though the route registers `delete "members"`, masking that the endpoint is DELETE-only and tempting readers to copy the wrong verb. Change the line to `xhr :delete, :remove_member, …` to match the `is able to remove a member` example.
totalPages reports an extra empty page when user_count is an exact multiple of limit — `totalPages` in `admin-group.js.es6` uses `Math.floor(user_count / limit) + 1`, which yields a phantom page when `user_count` is an exact multiple of `limit` and pushes `offset` past the data on `next`. Use `Math.ceil(user_count / limit)` so the pager only lists pages with content.