MiniMax M3 · Balanced

implement-access-token-context-encoding-framework-keycloak

Keycloak · Java · L · 300–799 lines · 6 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
0 of 0
Comments published
3
Comments matching a bug
0
Comments not matching
3
Cost of this PR
$0.197

Published comments (3)

mediumbugservices/src/main/java/org/keycloak/protocol/oidc/encode/AccessTokenContext.java:69-78

AccessTokenContext constructor re-validates grantType instead of rawTokenId — Replace `grantType` with `rawTokenId` in that null check.

mediumbugservices/src/main/java/org/keycloak/protocol/oidc/encode/AccessTokenContext.java:73

AccessTokenContext constructor uses grantType instead of rawTokenId in null check — The blank-check passes `grantType` while its message names `rawTokenId`, so a null `rawTokenId` is accepted silently. Pass `rawTokenId` to the `Objects.requireNonNull` argument instead.

mediumbugtestsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/AssertEvents.java:476-492

isAccessTokenId has inverted and mis-indexed grant-type check — The `isAccessTokenId` matcher in `AssertEvents` uses `substring(3, 5)` and a non-negated equality, so the grant check always passes and every well-formed token matches. Change to `!items[0].substring(4, 6).equals(expectedGrantShortcut)` to fix the off-by-index and the inversion. **Also found in:** - `testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/AssertEvents.java:30-35`

Gold bugs found (0)

None.

Gold bugs missed (0)

None.