MiniMax M3 · Balanced
optimize-header-layout-performance-with-flexbox-mixins-discourse-cursor
Discourse · Ruby · S · 30–99 lines · 5 files
The normal review, with one generalist agent. Judge: Claude Haiku 5.5.
- Gold bugs found
- 1 of 5
- Comments published
- 1
- Comments matching a bug
- 1
- Comments not matching
- 0
- Cost of this PR
- $0.099
Published comments (1)
mediumbugapp/assets/stylesheets/common/base/header.scss:14-21
Flex container placed on .contents instead of .row breaks header fallback — In the noscript fallback template, `.title` and `.panel` are inside a regular `.row` block, so `margin-left: auto` and `order: 3` on `.panel` are no-ops and the right alignment breaks. Apply the flex declarations to `.row` instead of `.contents`, or keep `float: right` on `.panel` for non-Ember pages.
Gold bugs found (1)
lowRemoving the float-based right alignment of .d-header .panel leaves the server-rendered (no-JS) header's login panel, which sits inside .row and is not a flex item, no longer right-aligned next to the title.
Gold bugs missed (4)
mediumThe flex-item styles target the inner .extra-info-wrapper instead of the component's root div, so in the flexbox header a long topic title keeps its full width and pushes the navigation panel out instead of being truncated.
lowThe align-items mixin emits no -moz-box-align, so on old Firefox versions using the display:-moz-box fallback the advertised vertical centering is not applied.
lowMaking .small-action a flex container leaves .small-action-desc content-sized (no flex:1), so the right-floated edit/delete buttons inside it sit right after short action descriptions instead of at the right edge of the row.
mediumOn mobile the .small-action custom message keeps margin-left:-40px, tuned for the old 4em left padding; with the new flex layout and 1.5% padding it is pulled into the avatar column and overlaps the icon.